Skip to content

Conversation

@soncuteanca
Copy link
Collaborator

@soncuteanca soncuteanca commented Nov 13, 2025

Relevant Links

Bugzilla: 1999899
TestRail: C3029292

Description of Code / Doc Changes

  • Changes on Firefox's side regarding add-on suggestion list. Updated accordingly!

Process Changes Required

Mark the relevant boxes:

  • Adds a dependency (rerun pipenv install)
  • Changes the BasePage
  • Changes or creates a BOM/POM (name the object model): _
  • Changes CI flow
  • Changes scheduled Beta or DevEdition
  • Changes Git hooks or Github settings
  • Changes L10n harness

Screenshots or Explanations

If you need to explain your code, do it here.

Comments or Future Work

Do we need to start another PR soon to address something you saw while working on this?

Workflow Checklist

  • Please request reviewers
  • If this is an unblocker, please post in Slack.
  • If asked to address comments, please resolve conversations.
  • If asked to change code, please re-request review from the person who wanted changes.

Thank you!

Tracy-Walker
Tracy-Walker previously approved these changes Nov 14, 2025
Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the wait needs to be extended to 10 seconds. Leave it for now.. But let's be sure to revert to 3 seconds when we get answer from search team about how to add back search terms betyond "grammar"

@Tracy-Walker
Copy link
Collaborator

Adi, said the test has been updated. Please review it and adjust this patch accordingly.

@soncuteanca soncuteanca marked this pull request as ready for review November 14, 2025 15:43
@soncuteanca soncuteanca changed the title [Fx changes - pending answers from search team] Anca/ Fix addon-suggestion Anca/ Fix addon-suggestion Nov 14, 2025
@Tracy-Walker Tracy-Walker self-requested a review November 14, 2025 16:25
Copy link
Collaborator

@Tracy-Walker Tracy-Walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@soncuteanca soncuteanca merged commit 284a7d4 into main Nov 14, 2025
24 checks passed
@soncuteanca soncuteanca deleted the anca/fix-addon-suggestion branch November 14, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants